Skip to content

fix: [Bug] README “Build from Source” instructions outdated. #3006#3022

Open
vaijosh wants to merge 4 commits into
apache:masterfrom
vaijosh:Hugegraph-3006-readmeAndM4Issue
Open

fix: [Bug] README “Build from Source” instructions outdated. #3006#3022
vaijosh wants to merge 4 commits into
apache:masterfrom
vaijosh:Hugegraph-3006-readmeAndM4Issue

Conversation

@vaijosh
Copy link
Copy Markdown

@vaijosh vaijosh commented May 11, 2026

Purpose of the PR

This PR updates the documentation to address two key issues:

  • The “Option 3: Build from Source” instructions in the README were outdated and did not match the actual directory structure or server startup process after building from source.
  • The bundled gremlin-console.sh fails on Apple Silicon (Mac M4) and with Java 17+ due to native library (Jansi) incompatibility and Java version requirements.

Main Changes

  • Updated the README to provide correct server startup steps after building from source, reflecting the actual directory structure.
  • Added a troubleshooting note in the “Verify Installation” section to inform users that gremlin-console.sh requires Java 11 and may fail on Apple Silicon (M1/M2/M3/M4) or with Java 17+.
  • Provided clear guidance and workarounds for users on affected platforms.

Verifying these changes

  • Trivial rework / doc update without any test coverage. (No Need)

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - Done

…Console troubleshooting for Mac M4 (Apple Silicon) (apache#3006)

- Fix outdated server startup steps in Option 3: Build from Source
- Add troubleshooting note for gremlin-console.sh failures on Apple Silicon and Java 17+
- Reference: apache#3006
@imbajin imbajin changed the title [Bug] Update README “Build from Source” instructions and add Gremlin Console troubleshooting for Mac M4 (Apple Silicon) (#3006) fix: update README & adapter Gremlin Console for Mac M4 May 19, 2026
@imbajin imbajin requested a review from Copilot May 19, 2026 14:19
@imbajin
Copy link
Copy Markdown
Member

imbajin commented May 19, 2026

Thanks for the PR. I checked this locally on macOS arm64 and I think there are two separate issues here.

First, the README build-from-source path is indeed outdated. The actual full distribution is produced as target/apache-hugegraph-${version}.tar.gz, and the server scripts are under apache-hugegraph-${version}/apache-hugegraph-server-${version}/bin/, not directly under install-dist/target/hugegraph-{version}. This part should be fixed as a documentation-only change and does not require adding a new dependency.

Second, the Apple Silicon Gremlin Console failure is real, but it is a separate compatibility problem in the current TinkerPop 3.5.1 / JLine / Jansi stack. Adding jansi:2.4.0 may be a possible workaround, but it is not the minimal fix for the README issue itself. If we want to claim that bundled bin/gremlin-console.sh works on Apple Silicon, we should add a macOS arm64 smoke test that actually runs the console, for example on macos-15:

VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)
SERVER_DIR="hugegraph-server/apache-hugegraph-server-${VERSION}"
printf "println \"gremlin-console-smoke-ok\"\n" > "$RUNNER_TEMP/gremlin-console-smoke.groovy"
"${SERVER_DIR}/bin/gremlin-console.sh" -- -e "$RUNNER_TEMP/gremlin-console-smoke.groovy"

Also, we are preparing to upgrade TinkerPop to 3.8. Since the official TinkerPop 3.8 Gremlin Console artifacts are already available and the current TinkerPop download page lists Gremlin Console / Server compatibility with Java 11/17, I think we should first verify whether the TinkerPop 3.8 upgrade already resolves the Jansi/JLine native-library issue before introducing a new direct dependency here.

So I would suggest splitting this PR:

  1. README path correction only, no dependency change.
  2. A separate Apple Silicon Gremlin Console compatibility fix, with macOS arm64 CI coverage if we decide to support the bundled console before the TinkerPop upgrade.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vaijosh
Copy link
Copy Markdown
Author

vaijosh commented May 19, 2026

Thanks @imbajin for the feedback.
I will create a separate ticket and PR for Mac issue. I will keep only readme changes in here.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 1.56%. Comparing base (8d095e1) to head (644b437).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8d095e1) and HEAD (644b437). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (8d095e1) HEAD (644b437)
4 2
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #3022       +/-   ##
============================================
- Coverage     36.15%   1.56%   -34.59%     
+ Complexity      403      43      -360     
============================================
  Files           812     781       -31     
  Lines         68307   65525     -2782     
  Branches       8927    8457      -470     
============================================
- Hits          24694    1026    -23668     
- Misses        40978   64413    +23435     
+ Partials       2635      86     -2549     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

vaijosh added 2 commits May 20, 2026 10:24
Implemented review comments
-Kept only changes related to README.md. We will have separate PR for mac sillicon issues.
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 20, 2026
@vaijosh
Copy link
Copy Markdown
Author

vaijosh commented May 20, 2026

Thanks for the PR. I checked this locally on macOS arm64 and I think there are two separate issues here.

First, the README build-from-source path is indeed outdated. The actual full distribution is produced as target/apache-hugegraph-${version}.tar.gz, and the server scripts are under apache-hugegraph-${version}/apache-hugegraph-server-${version}/bin/, not directly under install-dist/target/hugegraph-{version}. This part should be fixed as a documentation-only change and does not require adding a new dependency.

Second, the Apple Silicon Gremlin Console failure is real, but it is a separate compatibility problem in the current TinkerPop 3.5.1 / JLine / Jansi stack. Adding jansi:2.4.0 may be a possible workaround, but it is not the minimal fix for the README issue itself. If we want to claim that bundled bin/gremlin-console.sh works on Apple Silicon, we should add a macOS arm64 smoke test that actually runs the console, for example on macos-15:

VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)
SERVER_DIR="hugegraph-server/apache-hugegraph-server-${VERSION}"
printf "println \"gremlin-console-smoke-ok\"\n" > "$RUNNER_TEMP/gremlin-console-smoke.groovy"
"${SERVER_DIR}/bin/gremlin-console.sh" -- -e "$RUNNER_TEMP/gremlin-console-smoke.groovy"

Also, we are preparing to upgrade TinkerPop to 3.8. Since the official TinkerPop 3.8 Gremlin Console artifacts are already available and the current TinkerPop download page lists Gremlin Console / Server compatibility with Java 11/17, I think we should first verify whether the TinkerPop 3.8 upgrade already resolves the Jansi/JLine native-library issue before introducing a new direct dependency here.

So I would suggest splitting this PR:

  1. README path correction only, no dependency change.
  2. A separate Apple Silicon Gremlin Console compatibility fix, with macOS arm64 CI coverage if we decide to support the bundled console before the TinkerPop upgrade.

Hi @imbajin,
I have implemented the review comments. Separated the README.md changes from mac m4 issues.

@vaijosh vaijosh changed the title fix: update README & adapter Gremlin Console for Mac M4 [Bug] README “Build from Source” instructions outdated. #3006 May 20, 2026
@vaijosh vaijosh changed the title [Bug] README “Build from Source” instructions outdated. #3006 fix: [Bug] README “Build from Source” instructions outdated. #3006 May 20, 2026
@vaijosh
Copy link
Copy Markdown
Author

vaijosh commented May 20, 2026

Created separate issue #3031 for gremlin-console.sh errors on Mac M4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gremlin TinkerPop gremlin size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] README “Build from Source” instructions outdated.

3 participants