fix: [Bug] README “Build from Source” instructions outdated. #3006#3022
fix: [Bug] README “Build from Source” instructions outdated. #3006#3022vaijosh wants to merge 4 commits into
Conversation
…Console troubleshooting for Mac M4 (Apple Silicon) (apache#3006) - Fix outdated server startup steps in Option 3: Build from Source - Add troubleshooting note for gremlin-console.sh failures on Apple Silicon and Java 17+ - Reference: apache#3006
|
Thanks for the PR. I checked this locally on macOS arm64 and I think there are two separate issues here. First, the README build-from-source path is indeed outdated. The actual full distribution is produced as Second, the Apple Silicon Gremlin Console failure is real, but it is a separate compatibility problem in the current TinkerPop 3.5.1 / JLine / Jansi stack. Adding VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)
SERVER_DIR="hugegraph-server/apache-hugegraph-server-${VERSION}"
printf "println \"gremlin-console-smoke-ok\"\n" > "$RUNNER_TEMP/gremlin-console-smoke.groovy"
"${SERVER_DIR}/bin/gremlin-console.sh" -- -e "$RUNNER_TEMP/gremlin-console-smoke.groovy"Also, we are preparing to upgrade TinkerPop to 3.8. Since the official TinkerPop 3.8 Gremlin Console artifacts are already available and the current TinkerPop download page lists Gremlin Console / Server compatibility with Java 11/17, I think we should first verify whether the TinkerPop 3.8 upgrade already resolves the Jansi/JLine native-library issue before introducing a new direct dependency here. So I would suggest splitting this PR:
|
|
Thanks @imbajin for the feedback. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #3022 +/- ##
============================================
- Coverage 36.15% 1.56% -34.59%
+ Complexity 403 43 -360
============================================
Files 812 781 -31
Lines 68307 65525 -2782
Branches 8927 8457 -470
============================================
- Hits 24694 1026 -23668
- Misses 40978 64413 +23435
+ Partials 2635 86 -2549 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Implemented review comments -Kept only changes related to README.md. We will have separate PR for mac sillicon issues.
Hi @imbajin, |
|
Created separate issue #3031 for gremlin-console.sh errors on Mac M4 |
Purpose of the PR
This PR updates the documentation to address two key issues:
gremlin-console.shfails on Apple Silicon (Mac M4) and with Java 17+ due to native library (Jansi) incompatibility and Java version requirements.Main Changes
gremlin-console.shrequires Java 11 and may fail on Apple Silicon (M1/M2/M3/M4) or with Java 17+.Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - Done